Add the URL label to metrics securely #966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TwiN I hope this covers the issue raised in the previous PR. 🙌🏻 |
|
Thanks, @danlsgiga reference the PR @TwiN I have added a customizable label feature that covers the functionality of this pull request. You can view the pull request here. |
|
You can close this PR yourself. Let's continue the discussion in #979, and please help review it as well. |
|
If you prefer the label implementation, I'm fine with that! I do think the label implementation has a lot of perks, such as perhaps making exposing these labels on the UI as "tags" of sorts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small feature addition.
Sometimes is useful to have the endpoint URL in metrics labels so we can include that as part of alert messages when these metrics are scraped via prometheus.
This is related to #875 with the requested addition of sanitizing the URL to prevent query parameters, which may contain secrets, from leaking to metrics.
Additionaly, added a new test to validate query parameters are not being exposed.